Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

OTA enhancement. Split port and uploadPort in arduino.json #362

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

sernaleon
Copy link

This PR adds a new (optional) property in arduino.json, uploadPort. If defined, the user can specify an IP address or another COM port without closing the serial monitor. If not defined, uploadPort will default to port value, keeping the existing functionality.

Features:

  • When uploadPort is specified, this port is used for uploading the sketch.
  • When uploadPort is not defined, it uses the value specified in port.
  • If uploadPort and port are different, the serial monitor is not closed nor reopened.
  • If uploadPort is the same as port, it keeps functionality. It checks the serial monitor usage. In case of being used, it shuts it down and reopens it after the upload.
  • uploadPort can be either another serial port or an IP address.

Possible improvements:

  • Document functionality in README.md
  • Create a VSCode command

@shizn
Copy link
Contributor

shizn commented Jul 8, 2017

@yaohaizh @andxu

@yaohaizh
Copy link
Contributor

yaohaizh commented Jul 9, 2017

We might need differentiate the upload port with the serial port or OTA port. Current there are two issues here:

  1. We only show one port on the UI but provide two ports. This will confuse the user. We need provide multiple port on the UI yet we don't want to crowd the status bar; people already complain the croweded status bar.
  2. The change is not compatible with the old schema of arduino.json. Please take a look the file of ./misc/arduinoValidator.json For change on this file should be careful.

@sernaleon
Copy link
Author

@yaohaizh thank you for your feedback! Regading your comments.

  1. Indeed, the name might be confusing for some users. Maybe an improvement would be to rename it to otaIP or a name that does not look like a serial port at all. Regarding the UI, since this is a specific feature it might be acceptable for most users to just set the ip in a configuration file and do not have a command for this. Just an idea.
  2. I updated arduino.json and included the field, but it seems to me that i am overlooking something more.

@microsoft microsoft deleted a comment from msftclas Sep 26, 2017
@microsoft microsoft deleted a comment from msftclas Sep 26, 2017
@czgtest
Copy link
Contributor

czgtest commented Mar 6, 2018

yaohaizh try to do this, but not check in code at last, need to discuss again how to do it

@ArthurMa1978
Copy link
Member

@sernaleon sorry for the slow response, we are working on your pr, thank you for your contribution.

@liydu, from UX perspective, please help to check / design how to arrange 2 ports in the status bar.
@Sneezry and @czgtest please verify it.

@lanouettea
Copy link

Any update about this? I would really like to be able to upload my sketch using OTA.

@hairlesshobo
Copy link

Any update on this? I upload all my sketches using a programmer but need to use the serial monitor as well. From the description, it sounds like it wilt enable functionality to keep serial monitor open when uploading without being forced to change the serial port and close the serial monitor. This functionality is what I am used to with my previous arduino development platform (a plug in for visual studio) and would be a huge time-saver for me.

@benmcmorran benmcmorran changed the base branch from release to main January 13, 2022 22:49
@lersi
Copy link

lersi commented Apr 22, 2024

hello, I created a community fork at https://github.com/vscode-arduino/vscode-arduino.
You are more than welcome to merge your changes there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.