Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeromq for Mac M1 & other linux distros #5206

Closed
DonJayamanne opened this issue Mar 18, 2021 · 10 comments · Fixed by #13049
Closed

Zeromq for Mac M1 & other linux distros #5206

DonJayamanne opened this issue Mar 18, 2021 · 10 comments · Fixed by #13049
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug on-testplan

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Mar 18, 2021

Zeromq is used to communicate with kernels. If zeromq didn't work on an os, then we rely on users installing jupyter, which will install python and zeromq will get built on the os.
Mac m1 is an os for which we don't have a prebuilt binary.

  • I can confirm building zeromq works on Mac M1, & this works in a Mac

TODO:

  • Ship this as an experiment (for controlled roll out)
  • Consider contributing upstream
  • Sign & Build dependencies (build pipeline)
  • Should we sign & build dependencies for all OS & linux distros (even though we already have pre-built packages via npm)
  • How to detect what's a Mac M1
    • We could optionally load currrenly shipped zeromq and then if that fails, try our build.
    • Would require some changes to the zeromq package code or we'll need to update the files during runtime.
@greazer greazer added this to the May 2021 Release milestone Apr 1, 2021
@greazer greazer modified the milestones: May 2021 Release, June 2021 Release Apr 26, 2021
@DonJayamanne DonJayamanne changed the title Build zeromq for Mac M1 Build zeromq for Mac M1 & others Jul 21, 2021
@DonJayamanne DonJayamanne changed the title Build zeromq for Mac M1 & others Build zeromq for Mac M1 & other linux distros Jul 21, 2021
@greazer greazer modified the milestones: July 2021, August 2021 Jul 30, 2021
@greazer greazer modified the milestones: August 2021, old August 2021 Aug 9, 2021
@daler6

This comment has been minimized.

@DonJayamanne

This comment has been minimized.

@daler6

This comment has been minimized.

@DonJayamanne

This comment has been minimized.

@daler6

This comment has been minimized.

@xiajunwen1007
Copy link

xiajunwen1007 commented Dec 5, 2021

Any progress here? There is a similar issue caused by this #4.

@theelderbeever

This comment was marked as resolved.

@DonJayamanne

This comment was marked as off-topic.

@greazer greazer changed the title Build zeromq for Mac M1 & other linux distros Zeromq for Mac M1 & other linux distros Jun 10, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Jun 20, 2022
@DonJayamanne
Copy link
Contributor Author

Summary of discussion with @deepak1556

Build

Signing

  • Check with Steven/Isidor about signing contents in the vsix (are they signed today)

OS

Mac Universal?

@DonJayamanne DonJayamanne added the papercut 🩸 Something affecting the productivity of the team label Dec 5, 2022
@DonJayamanne DonJayamanne removed the papercut 🩸 Something affecting the productivity of the team label Dec 28, 2022
@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Mar 7, 2023

Internal (planning) notes

Notes
  • Turn off libsodium in our builds
    see Bartel-C8/zeromq.js@006f817
    DBUILD_SHARED=OFF -DWITH_DOCS=OFF -DWITH_LIBSODIUM=OFF`

  • Set the env variable for focring node-gyp to use 32
    $env:npm_config_arch="x86"

  • Invevstigate building using a single ubuntu with musl
    docker_cmd: apk add --no-cache pkgconfig curl tar python3 make gcc g++ cmake musl-dev && npm i -g pnpm && pnpm ins

Status

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants