feedback

microsoft · Nov 26, 2024 · 8c67f12 · 8c67f12
1 parent 54df1e4
commit 8c67f12
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/vs/workbench/contrib/preferences/browser/media/settingsEditor2.css b/src/vs/workbench/contrib/preferences/browser/media/settingsEditor2.css
@@ -522,6 +522,10 @@
 	opacity: 0.9;
 }
 
+.settings-editor > .settings-body .settings-tree-container .setting-item-contents .complex-object-edit-in-settings-button-container {
+	margin-top: 9px;
+}
+
 .settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-markdown a,
 .settings-editor > .settings-body .settings-tree-container .setting-item-contents .edit-in-settings-button,
 .settings-editor > .settings-body .settings-tree-container .setting-item-contents .setting-item-markdown a > code {

diff --git a/src/vs/workbench/contrib/preferences/browser/settingsTree.ts b/src/vs/workbench/contrib/preferences/browser/settingsTree.ts
@@ -1220,7 +1220,7 @@ class SettingComplexObjectRenderer extends SettingComplexRenderer implements ITr
 		const objectSettingWidget = common.toDispose.add(this._instantiationService.createInstance(ObjectSettingDropdownWidget, common.controlElement));
 		objectSettingWidget.domNode.classList.add(AbstractSettingRenderer.CONTROL_CLASS);
 
-		const openSettingsButton = DOM.append(common.controlElement, $('a.edit-in-settings-button'));
+		const openSettingsButton = DOM.append(DOM.append(common.controlElement, $('.complex-object-edit-in-settings-button-container')), $('a.complex-object.edit-in-settings-button'));
 		openSettingsButton.classList.add(AbstractSettingRenderer.CONTROL_CLASS);
 		openSettingsButton.role = 'button';
 
@@ -1240,7 +1240,6 @@ class SettingComplexObjectRenderer extends SettingComplexRenderer implements ITr
 	}
 
 	protected override renderValue(dataElement: SettingsTreeSettingElement, template: ISettingComplexObjectItemTemplate, onChange: (value: string) => void): void {
-		template.objectSettingWidget.domNode.classList.remove('hide');
 		const items = getObjectDisplayValue(dataElement);
 		template.objectSettingWidget.setValue(items, {
 			settingKey: dataElement.setting.key,