Fix cell selection state bugs #223794
Merged
Fix cell selection state bugs #223794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
approved these changes
Jul 25, 2024
nagi1999a
pushed a commit
to nagi1999a/vscode
that referenced
this pull request
Jul 26, 2024
fix selection bugs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #223343, #223345
Patch was made in
coreActions.tsto address the bug relating to hitting escape and the command no longer working.Bug is upstream in the cell list, when escape is hit, the editor loses the cell selection, however retains focus. Therefore, the selectedCells are not passed into the context of this action. Now, the selectedCells are determined by checking the selection, and if empty, taking the focus of the editor.