Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated issue template and issue reporter description length #234255

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,28 @@ about: Create a report to help us improve
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- 🔧 Launch with `code --disable-extensions` to check. -->

<!-- 🔧 Launch with `code --disable-extensions` or select `Reload With Extensions Disabled` from Command Palette to check. -->
Does this issue occur when all extensions are disabled?: Yes/No

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version:
- OS Version:

Steps to Reproduce:

1.
2.
I have searched the existing issues: Yes/No
I am using latest VSCode: Yes/No

- VS Code Version:
- OS Version:


### Current Behaviour:
<!-- Add details of the problem you encountered -->

### Expected Behaviour:
<!-- Add details of how the expected behaviour should be -->

### Steps to Reproduce:
<!-- Add minimal and clear steps and consider adding screenshots -->
1.
2.
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,7 @@ export class BaseIssueReporterService extends Disposable {
inputValidationMessage?.classList.remove('hidden');
descriptionShortMessage?.classList.add('hidden');
return false;
} else if (inputId === 'description' && inputElement.value.length < 10) {
} else if (inputId === 'description' && inputElement.value.length < 100) {
inputElement.classList.add('invalid-input');
descriptionShortMessage?.classList.remove('hidden');
inputValidationMessage?.classList.add('hidden');
Expand Down
32 changes: 31 additions & 1 deletion src/vs/workbench/contrib/issue/browser/issueService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,37 @@ export class BrowserIssueService implements IWorkbenchIssueService {
}

private getIssueUriFromStaticContent(baseUri: string, extension?: IExtensionDescription): string {
const issueDescription = `ADD ISSUE DESCRIPTION HERE
const issueDescription = `<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- 🔎 Search existing issues to avoid creating duplicates. -->
<!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->

<!-- 🔧 Select "Reload With Extensions Disabled" from Command Palette to check. -->
Does this issue occur when all extensions are disabled?: Yes/No

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->


I have searched the existing issues: Yes/No
I am using latest VSCode: Yes/No

- VS Code Version:
- OS Version:


### Current Behaviour:
<!-- Add details of the problem you encountered -->

### Expected Behaviour:
<!-- Add details of how the expected behaviour should be -->

### Steps to Reproduce:
<!-- Add minimal and clear steps and consider adding screenshots -->
1.
2.


Version: ${this.productService.version}
Commit: ${this.productService.commit ?? 'unknown'}
Expand Down