-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expand wdk-sys coverage to include gpio and parallel ports related headers #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97b8ac2
to
16e8cc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 10 changed files in this pull request and generated 2 comments.
Files not reviewed (4)
- crates/wdk-sys/src/lib.rs: Evaluated as low risk
- crates/wdk-build/src/lib.rs: Evaluated as low risk
- examples/sample-umdf-driver/Cargo.toml: Evaluated as low risk
- crates/wdk-sys/Cargo.toml: Evaluated as low risk
Co-authored-by: Copilot <[email protected]> Signed-off-by: Melvin Wang <[email protected]>
ankurung
previously approved these changes
Feb 3, 2025
ankurung
previously approved these changes
Feb 6, 2025
Signed-off-by: Melvin Wang <[email protected]>
dd90b6e
to
a5b5c0b
Compare
leon-xd
approved these changes
Feb 6, 2025
ankurung
approved these changes
Feb 6, 2025
hamzamust
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for GPIO and Parallel Ports drivers to the
wdk-sys
crate. The changes include updates to the API subsets, configuration, feature flags, and binding generation for these new driver types.API Subset Additions:
Gpio
andParallelPorts
to theApiSubset
enum incrates/wdk-build/src/lib.rs
.Configuration Updates:
Config
implementation to include header files forGpio
andParallelPorts
based on the driver configuration incrates/wdk-build/src/lib.rs
[1] [2].Feature Flags:
gpio
andparallel-ports
features toCargo.toml
files forwdk-sys
and example drivers [1] [2] [3] [4].Binding Generation:
generate_gpio
andgenerate_parallel_ports
incrates/wdk-sys/build.rs
[1] [2].BINDGEN_FILE_GENERATORS_TUPLES
array and conditional compilation for constants and types generation [1] [2] [3].New Binding Files:
gpio.rs
andparallel_ports.rs
tocrates/wdk-sys/src/
with the necessary bindings and documentation [1] [2].