Add ODS logger and use it during init #4969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
approved these changes
Nov 19, 2024
Comment on lines
+81
to
+90
| Logging::OutputDebugStringLogger::Remove(); | ||
| #endif | ||
|
|
||
| Logging::UseGlobalTelemetryLoggerActivityIdOnly(); | ||
|
|
||
| Execution::Context context{ std::cout, std::cin }; | ||
| auto previousThreadGlobals = context.SetForCurrentThread(); | ||
| auto previousThreadGlobals = context.SetForCurrentThread(); | ||
|
|
||
| // Set up debug string logging during initialization | ||
| Logging::OutputDebugStringLogger::Add(); |
There was a problem hiding this comment.
I don't see why we have to remove the ODS logger only to add it immediately after. Couldn't we just add it before the #ifndef and remove it once in line 97?
There was a problem hiding this comment.
The first one is added to the global logger, while the second one is added to the context logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
The user settings (and then group policy) initialization happen before we get the file logger set up. To be able to see into what is happening there more easily, this change creates a logger that uses
OutputDebugStringand uses it during the initial file logger creation.Validation
Debugged and saw the group policy and settings logging come through the output.
Microsoft Reviewers: Open in CodeFlow