Skip to content

Commit

Permalink
fixes #39 and other issues
Browse files Browse the repository at this point in the history
  • Loading branch information
midhunhk committed Jun 22, 2024
1 parent 32a24d8 commit f4fb50b
Show file tree
Hide file tree
Showing 16 changed files with 24 additions and 14 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ build/
gradle/
app/AeAppsLibrary.iml
sample/release/
.kotlin/sessions/

# Local configuration file (sdk path, etc)
local.properties
Expand Down
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ plugins {

id("com.android.application") version "8.5.0" apply false
id("com.android.library") version "8.5.0" apply false
id("org.jetbrains.kotlin.android") version "2.0.0-Beta5" apply false
id("org.jetbrains.kotlin.android") version "2.0.0" apply false
id("maven-publish")
}
9 changes: 5 additions & 4 deletions buildSrc/src/main/java/com/ae/apps/lib/Dependencies.kt
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ object Libs {
const val CONSTRAINT_LAYOUT = "androidx.constraintlayout:constraintlayout:2.1.4"
}

object Kotlin{
const val KTX_CORE = "androidx.core:core-ktx:1.13.1"
}

object Google {
const val GUAVA = "com.google.guava:guava:31.0.1-android"
}
Expand All @@ -24,6 +20,11 @@ object Libs {
private const val BILLING_VERSION = "6.2.0"
const val BILLING_CLIENT = "com.android.billingclient:billing:$BILLING_VERSION"
const val IN_APP_REVIEW = "com.google.android.play:review:2.0.1"

object Kotlin{
const val IN_APP_REVIEW = "com.google.android.play:review-ktx:2.0.1"
const val IN_APP_UPDATE = "com.google.android.play:app-update-ktx:2.1.0"
}
}

object Material {
Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/java/com/ae/apps/lib/Publish.kt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package com.ae.apps.lib

object Publish {
const val GROUP_ID = "com.github.midhunhk.lib-aeapps"
const val VERSION_STRING = "5.0.0-alpha.20"
const val VERSION_STRING = "5.0.0-alpha.21"
}

object ArtifactId {
Expand Down
3 changes: 1 addition & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
org.gradle.jvmargs=-Xmx2048m -Dfile.encoding=UTF-8
#org.gradle.unsafe.configuration-cache=false
#android.enableJetifier=true
android.useAndroidX=true
android.nonTransitiveRClass=true
org.gradle.configuration-cache=true
1 change: 0 additions & 1 deletion modules/billing-client/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ dependencies {
implementation (Libs.AndroidX.APPCOMPAT)
implementation (Libs.GooglePlay.BILLING_CLIENT)
implementation (Libs.Google.GUAVA)
implementation (Libs.Kotlin.KTX_CORE)

testImplementation (Libs.Test.JUNIT)
androidTestImplementation (Libs.Test.TEST_RUNNER)
Expand Down
Empty file.
1 change: 0 additions & 1 deletion modules/database-helpers/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ kotlin {

dependencies {
api (project(":core"))
implementation(Libs.Kotlin.KTX_CORE)

testImplementation(Libs.Test.JUNIT)
testImplementation(Libs.Test.MOCKITO_CORE)
Expand Down
Empty file.
14 changes: 12 additions & 2 deletions modules/mocks/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.ae.apps.lib.Publish
plugins {
id ("com.android.library")
id ("maven-publish")
id ("org.jetbrains.kotlin.android")
}

android {
Expand Down Expand Up @@ -36,8 +37,8 @@ android {
}
}
compileOptions {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}
}

Expand All @@ -56,10 +57,19 @@ afterEvaluate {
}
}

kotlin {
jvmToolchain {
languageVersion.set(JavaLanguageVersion.of(17))
}

jvmToolchain(17)
}

dependencies {
api (project(":core"))

implementation(Libs.AndroidX.APPCOMPAT)
implementation("androidx.core:core-ktx:1.13.1")

androidTestImplementation (Libs.Test.TEST_RUNNER)
androidTestImplementation (Libs.Test.MOCKITO_CORE)
Expand Down
Empty file.
Empty file.
Empty file.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class MockSmsApiGateway extends AbstractSmsApiGateway {

public static final int MESSAGE_INFO_COUNT = 5;

public void setContentResoler(final ContentResolver contentResolver){
public void setContentResolver(final ContentResolver contentResolver){
this.contentResolver = contentResolver;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class SmsApiGatewayTest {
@Before
public void setUp() {
MockSmsApiGateway mockSmsApiGateway = new MockSmsApiGateway();
mockSmsApiGateway.setContentResoler(contentResolver);
mockSmsApiGateway.setContentResolver(contentResolver);
apiGateway = mockSmsApiGateway;
}

Expand Down
1 change: 1 addition & 0 deletions modules/utilities/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.ae.apps.lib.Publish
plugins {
id ("com.android.library")
id ("maven-publish")
id ("org.jetbrains.kotlin.android")
}
android {
namespace = "com.ae.apps.lib.utilities"
Expand Down

0 comments on commit f4fb50b

Please sign in to comment.