Skip to content

Commit

Permalink
Staging with running VM would stop the offline transfer (#1396)
Browse files Browse the repository at this point in the history
because it thought it was a cutover and a VM was started

This fixes this by only running that check when doing
a cutover

Signed-off-by: Alexander Wels <[email protected]>
  • Loading branch information
awels authored Nov 20, 2024
1 parent fc81f94 commit 7652ee4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/controller/directvolumemigration/rsync.go
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,7 @@ func (t *Task) createRsyncTransferClients(srcClient compat.Client,
// Check if PVC is now part of the running VMs PVs, if so we need to cancel the in progress rsync, and
// that should trigger a live migration or a new rsync operation after it stops the VM.
for _, pvcPair := range unfilteredUncompletedBlockOrVMPvcList {
if pvcPair.Source().Claim().Name == newOperation.PVCReference.Name && pvcPair.Source().Claim().Namespace == newOperation.PVCReference.Namespace {
if t.Owner.IsCutover() && pvcPair.Source().Claim().Name == newOperation.PVCReference.Name && pvcPair.Source().Claim().Namespace == newOperation.PVCReference.Namespace {
runningVMVolumes, err := t.getRunningVMVolumes([]string{newOperation.PVCReference.Namespace})
if err != nil {
currentStatus.AddError(err)
Expand Down

0 comments on commit 7652ee4

Please sign in to comment.