fix(Makefile): docker-buildx do not add duplicate --platform
#182
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Tiger Kaovilai <[email protected]>
There was a problem hiding this comment.
While it could be argued that this target does not work with podman, it's from kubebuilder template which also use the same $(CONTAINER_TOOL).
And I am PR'ing into kubebuilder in kubernetes-sigs/kubebuilder#4545
There was a problem hiding this comment.
There was a problem hiding this comment.
@kaovilai it's your call if we want to add it or not, but it should be commented that it differs from upstream kubebuilder, so we don't simply replace it in the future by following for example instructions like:
https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.34.0/
e.g. Without clear comment to the developer I would replace everything within docker-buildix including diff from upstream kubebuilder.
There was a problem hiding this comment.
@kaovilai could you please add the comment to the code and I will approve?
There was a problem hiding this comment.
or do you prefer a third target that would not conflict with kubebuilder scaffold?
There was a problem hiding this comment.
@kaovilai that is cool idea (third target) - I like it more then comment.
Signed-off-by: Tiger Kaovilai [email protected]
Why the changes were made
Same motivation as kubernetes-sigs/kubebuilder#4545
How to test the changes made
run
make docker-buildxin this repo