Introduce state file on s3 bucket #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds the idea of configuring an s3 bucket as the holder of the state file #49
mihai-satmarean
requested review from
alexteo,
BlackText,
Dumi25,
ionmariana531,
LuffyD83,
sebbastianG,
adrian-ilea,
MariusB-DevOps,
melania27dev and
Alllexia
improved handling
try some magic with statefiles and buckets
Add aws cli verification for stating the objects were created, and destroy at the end. Dont error if the state bucket exists
trying to capture theoutputs and ise aws cli to verify
try changing folder to module path
we need to make sure that the correct IDs are passed on to subsequent calls
mihai-satmarean
commented
Dec 5, 2024
| run-name: ${{ github.actor }} is deploying on AWS 🚀 | ||
| on: | ||
| push: | ||
| branches: | ||
| - feature/aws-s3-module | ||
| - mihai-satmarean-patch-1 |
There was a problem hiding this comment.
Aici trebuie sa gasim un mod sa mearga si pe alte branchuri decat hardcodat.
Inspiratie aici https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#using-filters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the idea of configuring an s3 bucket as the holder of the state file
#49