Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miic v2 (tmiic) #131

Merged
merged 18 commits into from
Jun 19, 2024
Merged

Miic v2 (tmiic) #131

merged 18 commits into from
Jun 19, 2024

Conversation

franck-simon
Copy link
Collaborator

tMIIC version including review feedbacks and more

@louis-montagne louis-montagne marked this pull request as ready for review May 21, 2024 13:22
R/miic.R Outdated Show resolved Hide resolved
R/tmiic.plot.R Outdated Show resolved Hide resolved
R/tmiic.plot.R Outdated Show resolved Hide resolved
R/tmiic.plot.R Show resolved Hide resolved
R/tmiic.plot.R Outdated Show resolved Hide resolved
R/tmiic.utils.R Outdated Show resolved Hide resolved
R/tmiic.utils.R Outdated Show resolved Hide resolved
R/tmiic.utils.R Outdated Show resolved Hide resolved
R/tmiic.utils.R Outdated Show resolved Hide resolved
R/tmiic.utils.R Outdated Show resolved Hide resolved
R/tmiic.utils.R Outdated Show resolved Hide resolved
R/tmiic.utils.R Outdated Show resolved Hide resolved
R/tmiic.utils.R Outdated Show resolved Hide resolved
R/tmiic.utils.R Outdated Show resolved Hide resolved
# - input_data: a dataframe with the time steps in the 1st column
# A new trajectory is identified when time step < previous time step
# - check: optional, default=T. Emit warnings when:
# * there is a gap between 2 consecutive time steps
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EN (OD)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain more please

R/tmiic.utils.R Outdated Show resolved Hide resolved
R/tmiic.utils.R Outdated Show resolved Hide resolved
R/tmiic.utils.R Outdated Show resolved Hide resolved
#' time series/time steps as rows.
#' The time step information must be supplied in the first column and,
#' for each time series, be consecutive and in ascending order (increment of 1).
#' Multiple trajectories can be provided, the function will consider that a
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EN (OD) (missing *as)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain more please

R/tmiic.utils.R Outdated Show resolved Hide resolved
R/tmiic.wrapper.R Outdated Show resolved Hide resolved
R/tmiic.wrapper.R Outdated Show resolved Hide resolved
man/estimateTemporalDynamic.Rd Show resolved Hide resolved
man/estimateTemporalDynamic.Rd Show resolved Hide resolved
src/mutual_information.cpp Show resolved Hide resolved
src/tmiic.cpp Outdated Show resolved Hide resolved
Copy link

@louis-montagne louis-montagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comment more than orianne

@franck-simon franck-simon merged commit b150287 into master Jun 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants