MIIC v2.0.1: Preparation of CRAN update submission, group all breaking changes. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
franck-simon
commented
Aug 26, 2024
franck-simon
commented
- Inclusion of the changes considered for a very long time from the output branch
- standardize the naming in function, parameters, returned values
franck-simon
requested review from
louise-rb-dupuis,
O-mics and
louis-montagne
O-mics
approved these changes
Aug 26, 2024
| #' Please note that the order is important: in standard mode, "var1 var2" will | ||
| #' be interpreted as var1 -> var2 and in temporal mode, "var1 var2 3" is | ||
| #' interpreted as var1_lag3 -> var2_lag0. Please note also that, in temporal | ||
| #' mode, for contextual variables that are not lagged, the expected value in the |
There was a problem hiding this comment.
(By definition, contextual variables are not lagged Therefore the expected value... (sorry, really tiny comment))
| #' When consistency is activated, \emph{ori_consensus_ratio} is used as | ||
| #' threshold when deducing the type of an consensus edge tip (head/tail) | ||
| #' from the average probability of orientations over the cycle of graphs. | ||
| #' For a given edge tip, denote by p the average probability of it being a head, |
franck-simon
changed the title
O-mics
reviewed
Sep 2, 2024
louise-rb-dupuis
approved these changes
Sep 10, 2024
|
Great modifications and re-organization ! :) |
louis-montagne
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.