-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove styled-components (closes #56) #113
Conversation
Thanks @Gustl22 for your hard work! I review your PR ASAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my tests, I see one change: button stay focused and highlighted which was not the case previously. See the blue highlight
Instead of
Compare using:
https://mikbry.github.io/material-ui-color/?path=/story/components-colorpalette--basic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some linting/prettier errors i got using VSCode
Sorry I'll make the changes the upcoming week. Thx for reviewing :) |
Sorry can you explain more detailed? On your mentioned deployed storybook colorpalette, I also get a highlight after clicking on it (tested on Chrome and Firefox). |
I just tested again and all is fine ;-) |
There is one conflict in yarn.lock, do you fix it or i do ? after that i will merge |
Sure, I can do it quickly :) |
# Conflicts: # yarn.lock
Ok, do it ;-) |
Sorry, I found one more issue with the transparent palette. I'll let you know, when ready :) |
Ready now 😅 I also completely refreshed the yarn.lock, if thats ok, in order to not mess up the previous conflicts. |
Well done, thanks @Gustl22 ! |
Fix issues
Description
ColorButton
cannot performed completely, most likely due to: Cascading of inline styles jsdom/jsdom#1696 and Internal/embedded <style> tags don't cascade correctly jestjs/jest#8464styled-components
and they actually save their style-rules for each class and look them up if needed, e.g. when testing. As far as I understood they actually not loading the style rules from the DOM.I actually only went through the storybook and checked if anything jumped into my eye. Not sure if I covered all cases a 100%.
Check List
Review targets: