Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of pip when non-root on Debian systems #37

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

u1f35c
Copy link
Contributor

@u1f35c u1f35c commented Jun 12, 2018

pip defaults to user mode when non-root on Debian systems, causing an
error when building haaska.zip. Add --system to force system mode and
enable building as a regular user.

@mike-grant mike-grant self-requested a review June 12, 2018 20:46
@mike-grant mike-grant self-assigned this Jun 12, 2018
@anthonylavado
Copy link
Contributor

Looks like this was proposed in the original Haaska, but due to concerns, it wasn’t implemented: auchter/haaska#70

pip defaults to user mode when non-root on Debian systems, causing an
error when building haaska.zip. Add --system on Debian based setups to
force system mode and enable building as a regular user.
@u1f35c
Copy link
Contributor Author

u1f35c commented Jun 13, 2018

Well that's annoying. Respun with a check to see if we have /etc/debian_version, which should mean we only add --system for anything based on Debian.

@anthonylavado
Copy link
Contributor

@u1f35c Thanks for that update. I haven’t looked in the root issue much, but apparently it’s the source of some debate.

@mike-grant LGTM here. Merge?

@mike-grant mike-grant merged commit e3543c8 into mike-grant:master Jun 21, 2018
@duckpuppy
Copy link

duckpuppy commented Oct 12, 2018

Actually... I'm building this on Debian Stretch, and I get the no such option: --system error referenced in #52 without using docker to build, just simply using make deploy.

pip install --help indeed shows --user, but no --system. This is from pip 18.0

If I edit the Makefile and remove all the extra detection logic for debian, I can build just fine as a normal user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants