Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make master branch works correctly.
ember -v
ember-cli: 3.27.0 node: 12.22.6 os: darwin x64
fix: build failed; downgrade to classic ember edition
We must downgrade to last 3.x ember version to still use ember classic edition.
https://deprecations.emberjs.com/v3.x/#toc_editions-classic
fix: deprecation and errors array.new-array-wrapper
We must fix new A deprecation, because it until: 3.9.0 and throw errors
fix: tooltip undefined handleMouseLeave_
just fixed
fix: active tab attribute is not working /issues/134
It's happend because this.get('composableChildren').length is
0
, so child tabs aren't rendered at parent didInsertElement.Thanks for contributing to this library! Please make sure that
So, now addon works with octane and classic ember editions and have passed tests.
Hi @mike-north Please let me know what do you think it's enough for merge/release new tag?