Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with ember 3.x #563

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

aplex-dex
Copy link

@aplex-dex aplex-dex commented Jan 28, 2022

Let's make master branch works correctly.

ember -v
ember-cli: 3.27.0 node: 12.22.6 os: darwin x64

Thanks for contributing to this library! Please make sure that

  • You've written some tests to go along with your code
  • The automated testing passes successfully (without lint, we have 62 failed lint test now)
  • You've updated the documentation (the dummy app for this addon) as appropriate (no required updates)
  • You've provided an explanation as to what this feature/fix does, so that others can understand the intent while reviewing the code

So, now addon works with octane and classic ember editions and have passed tests.

Hi @mike-north Please let me know what do you think it's enough for merge/release new tag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant