phone number type lower bound change (#41)

* data source links applied, type renaming * phone parser * unmarshalling empty value fix * empty value unmarshalling fix * ipv6 implementation * ip dual stack implementation * phone number type lower bound change --------- Co-authored-by: ivan-lemiashonak <[email protected]>
mikekonan · Mar 7, 2024 · fb2f020 · fb2f020
1 parent 48b6bc9
commit fb2f020
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/phone/number.go b/phone/number.go
@@ -33,8 +33,8 @@ func (number Number) Validate() error {
 		return fmt.Errorf("'%s' is not valid phone number", number)
 	}
 
-	// minimum length is 7 for Saint Helena (Format: +290 XXXX) and Niue (Format: +683 XXXX)
-	if len(number) < 7 || len(number) > 15 {
+	// minimum length is 5 for Saint Helena (Format: +290 XXXXX)
+	if len(number) < 5 || len(number) > 15 {
 		return fmt.Errorf("'%s' is not valid phone number", number)
 	}
 

diff --git a/phone/number_test.go b/phone/number_test.go
@@ -15,7 +15,7 @@ var testNumberCases = []struct {
 }{
 	{testValue: "", expectingValidateError: true, expectingValueError: false, expectingUnmarshalError: false},
 	{testValue: "123", expectingValidateError: true, expectingValueError: true, expectingUnmarshalError: true},
-	{testValue: "123456", expectingValidateError: true, expectingValueError: true, expectingUnmarshalError: true},
+	{testValue: "12345", expectingValidateError: false, expectingValueError: false, expectingUnmarshalError: false},
 	{testValue: "1234", expectingValidateError: true, expectingValueError: true, expectingUnmarshalError: true},
 	{testValue: "1234567", expectingValidateError: false, expectingValueError: false, expectingUnmarshalError: false},
 	{testValue: "1234567890", expectingValidateError: false, expectingValueError: false, expectingUnmarshalError: false},