💎 Improve emoji search

When filtering emojis, the descrption was the only text that could be searched. By adding the emoji shortcode to the known terms, it will allow for the visual representation of the emoji to be part of the search.
mikelorant · Mar 4, 2024 · c348413 · c348413
1 parent 61afb5f
commit c348413
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/internal/ui/header/emoji.go b/internal/ui/header/emoji.go
@@ -50,6 +50,7 @@ func (i listItem) FilterValue() string {
 func (i fuzzyItem) Terms() []string {
 	return []string{
 		i.emoji.Description,
+		i.emoji.Shortcode,
 	}
 }
 

diff --git a/internal/ui/header/testdata/filter_emoji.golden b/internal/ui/header/testdata/filter_emoji.golden
@@ -5,12 +5,12 @@
     ┌──────────────────────────────────────────────────────────────────────────┐
     │? Choose an emoji: bug                                                  ● │
     │❯ 🐛 - Fix a bug.                                                         │
+    │  🏗  - Make architectural changes.                                        │
     │  👔 - Add or update business logic.                                      │
     │                                                                          │
     │                                                                          │
     │                                                                          │
     │                                                                          │
     │                                                                          │
     │                                                                          │
-    │                                                                          │
     └──────────────────────────────────────────────────────────────────────────┘
diff --git a/internal/ui/header/testdata/select_emoji_filter.golden b/internal/ui/header/testdata/select_emoji_filter.golden
@@ -5,12 +5,12 @@
     ┌──────────────────────────────────────────────────────────────────────────┐
     │? Choose an emoji: bug                                                  ● │
     │❯ 🐛 - Fix a bug.                                                         │
+    │  🏗  - Make architectural changes.                                        │
     │  👔 - Add or update business logic.                                      │
     │                                                                          │
     │                                                                          │
     │                                                                          │
     │                                                                          │
     │                                                                          │
     │                                                                          │
-    │                                                                          │
     └──────────────────────────────────────────────────────────────────────────┘