Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Add vi (Vietnamese) language #179

Merged
merged 4 commits into from
Dec 6, 2024
Merged

new: Add vi (Vietnamese) language #179

merged 4 commits into from
Dec 6, 2024

Conversation

ZoloPro
Copy link
Contributor

@ZoloPro ZoloPro commented Nov 17, 2024

No description provided.

@ZoloPro
Copy link
Contributor Author

ZoloPro commented Nov 26, 2024

@milesj Please help me review this pull request. If anything needs to be changed, just let me know.

@milesj
Copy link
Owner

milesj commented Nov 26, 2024

@ZoloPro This will need to wait until this PR lands: #180

@milesj
Copy link
Owner

milesj commented Dec 4, 2024

That PR landed if you want to rebase, regenerate data, and translate the new messages.

@ZoloPro
Copy link
Contributor Author

ZoloPro commented Dec 4, 2024

@milesj I have updated the pull request. Could you please review it?

@milesj
Copy link
Owner

milesj commented Dec 4, 2024

@ZoloPro Just need to add a changeset with yarn bump.

It also looks like tests keep hanging. You probably need to update this: https://github.com/milesj/emojibase/blob/master/packages/regex/shortcode-native.js

@ZoloPro
Copy link
Contributor Author

ZoloPro commented Dec 6, 2024

@ZoloPro Just need to add a changeset with yarn bump.

It also looks like tests keep hanging. You probably need to update this: https://github.com/milesj/emojibase/blob/master/packages/regex/shortcode-native.js

I have updated

@milesj
Copy link
Owner

milesj commented Dec 6, 2024

Looks good. No idea why that check is failing, probably because its a fork?

Will merge anyways.

@milesj milesj merged commit e9b9a9a into milesj:master Dec 6, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants