Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to add non MilkyWay address to the trusted delegates #211

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

manu0466
Copy link
Contributor

@manu0466 manu0466 commented Dec 5, 2024

Description

Closes: #XXXX

This PR fixes a bug that prevents adding non-MilkyWay addresses to the TrustedDelegates of the x/liquidvesting module, which blocks deposits from other chains.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@manu0466 manu0466 self-assigned this Dec 5, 2024
@RiccardoM RiccardoM merged commit bc2681d into main Dec 6, 2024
18 of 19 checks passed
@RiccardoM RiccardoM deleted the manuel/fix-liquidvesting-deposit branch December 6, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants