Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix scaling gas problem #242

Merged
merged 3 commits into from
Jan 16, 2025
Merged

fix: fix scaling gas problem #242

merged 3 commits into from
Jan 16, 2025

Conversation

hallazzang
Copy link
Contributor

@hallazzang hallazzang commented Jan 15, 2025

Description

We're currently experiencing too high gas usage per delegation. This PR fixes the problem.

Since delegations don't have an impact on chain's performance anymore, we can safely remove it now.

Closes: MILK-202


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

since delegations don't have an impact on chain's performance anymore,
we can safely remove it now
Copy link

github-actions bot commented Jan 15, 2025

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 16, 2025, 7:23 AM

@hallazzang hallazzang marked this pull request as ready for review January 15, 2025 07:28
@hallazzang hallazzang requested a review from RiccardoM January 16, 2025 07:23
@RiccardoM RiccardoM merged commit a0c1a7d into main Jan 16, 2025
19 checks passed
@RiccardoM RiccardoM deleted the hallazzang/fix-scaling-gas branch January 16, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants