Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #50

Merged
merged 2 commits into from
Jul 15, 2024
Merged

chore: fix typos #50

merged 2 commits into from
Jul 15, 2024

Conversation

hallazzang
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@hallazzang hallazzang self-assigned this Jul 11, 2024
@hallazzang hallazzang marked this pull request as ready for review July 15, 2024 07:57
@hallazzang hallazzang requested review from manu0466 and RiccardoM July 15, 2024 07:57
Copy link
Contributor

@manu0466 manu0466 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only suggest to change the PR name to "refactor: fix typos" since here we aren't fixing bugs.

@RiccardoM RiccardoM changed the title fix: fix typos chore: fix typos Jul 15, 2024
@RiccardoM
Copy link
Contributor

@hallazzang Can you fix the conflict please?

@hallazzang hallazzang requested a review from RiccardoM July 15, 2024 12:24
@RiccardoM RiccardoM merged commit a75eec9 into main Jul 15, 2024
17 checks passed
@RiccardoM RiccardoM deleted the hallazzang/fix-typos branch July 15, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants