Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make tickers module keep token exponents too #89

Closed
wants to merge 3 commits into from

Conversation

hallazzang
Copy link
Contributor

Description

Instead of simply keeping denom-ticker mappings, this PR introduces new Asset type which holds the exponent as well. With this change it's possible to calculate dollar values of an asset correctly with assets with different exponents.

Closes: MILK-66

See #78 for previous discussions.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@hallazzang hallazzang self-assigned this Aug 20, 2024
@hallazzang hallazzang marked this pull request as ready for review August 20, 2024 17:06
@hallazzang
Copy link
Contributor Author

Sorry for confusion, closing this since I force-pushed cherry-picked commits to #78 and reopened it.

@hallazzang hallazzang closed this Aug 21, 2024
@RiccardoM RiccardoM deleted the hallazzang/new-ticker-exponent branch August 27, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant