Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gonum version #19

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Update gonum version #19

merged 2 commits into from
Jan 19, 2025

Conversation

milosgajdos
Copy link
Owner

@milosgajdos milosgajdos commented Jan 19, 2025

Important

Update Go version and dependencies, including Gonum, in CI and project configuration files.

  • CI Configuration:
    • Update Go versions in .github/workflows/ci.yaml from 1.21, 1.22 to 1.22, 1.23.
    • Update golangci-lint version from v1.58 to v1.63.
  • Dependencies:
    • Update go.mod to use Go 1.22 and toolchain go1.23.4.
    • Update gonum.org/v1/gonum to v0.15.1 and gonum.org/v1/plot to v0.14.0 in go.mod.
    • Update indirect dependencies in go.mod including git.sr.ht/~sbinet/gg, github.com/go-fonts/liberation, and github.com/go-latex/latex.
  • Dependency Checksums:
    • Update go.sum to reflect new dependency versions and checksums.

This description was created by Ellipsis for 2c36b57. It will automatically update as commits are pushed.

Signed-off-by: Milos Gajdos <[email protected]>
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8ec4dc3 in 24 seconds

More details
  • Looked at 188 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. go.mod:5
  • Draft comment:
    The toolchain go1.23.4 directive is not standard and might cause compatibility issues. Consider removing it unless there's a specific need.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_s6Dg5dUmMQEz2JGA


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Signed-off-by: Milos Gajdos <[email protected]>
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 2c36b57 in 12 seconds

More details
  • Looked at 28 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/ci.yaml:18
  • Draft comment:
    Ensure that the codebase is compatible with Go 1.23, as the CI configuration now includes this version.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR updates the Go versions in the CI workflow from 1.21 and 1.22 to 1.22 and 1.23. This is a straightforward update, but it's important to ensure that the codebase is compatible with the new Go versions. Additionally, the linter version is updated from v1.58 to v1.63, which should be checked for compatibility as well.

Workflow ID: wflow_GMYBEKGrJ3BnSVQg


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@milosgajdos milosgajdos merged commit 3866350 into master Jan 19, 2025
4 checks passed
@milosgajdos milosgajdos deleted the update-gonum branch January 19, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant