Update disk_index.md #2851
Merged
Update disk_index.md #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @AnthonyTsu1984 |
AnthonyTsu1984
approved these changes
Nov 13, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AnthonyTsu1984, nish112022 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the issue: #2853
There seems to be a mismatch between the diskANN configs:
https://github.com/milvus-io/milvus/blob/master/configs/milvus.yaml
Below is for indexNode, here it is enabled.
and here for queryNode, it is disabled.
Based on my understanding it seems it should be indexNode.diskANN as index node will do the indexing.