Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support to replicate import msg #39171

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: support to replicate import msg #39171

wants to merge 4 commits into from

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Jan 11, 2025 •
edited
Loading

@sre-ci-robot sre-ci-robot added the do-not-merge/work-in-progress Don't merge even CI passed. label Jan 11, 2025
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/dependency Pull requests that update a dependency file area/internal-api labels Jan 11, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SimFG
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 11, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 11, 2025

@SimFG Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@SimFG SimFG force-pushed the master branch 18 times, most recently from 6ed4694 to 9191fb5 Compare January 17, 2025 07:42
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Feb 13, 2025

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Feb 13, 2025

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Feb 13, 2025

rerun go-sdk

@SimFG
Copy link
Contributor Author

SimFG commented Feb 13, 2025

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

jaime0815
jaime0815 reviewed Feb 13, 2025
View reviewed changes
internal/datacoord/import_checker.go Show resolved Hide resolved
internal/datacoord/import_checker.go
@@ -381,6 +393,22 @@ func (c *importChecker) checkIndexBuildingJob(job ImportJob) {
return
}

// wait l0 segment import and block l0 compaction
log.Info("start to pause l0 segment compacting", zap.Int64("jobID", job.GetJobID()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloud you refactor the block l0 compaction code, and consider using a pause or resume signal to trigger the metadata changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

internal/datanode/msghandlerimpl/msg_handler_impl.go Show resolved Hide resolved
internal/flushcommon/pipeline/flow_graph_dd_node.go Show resolved Hide resolved
internal/streamingnode/server/flusher/flusherimpl/msg_handler_impl.go Show resolved Hide resolved
internal/datacoord/services.go Outdated Show resolved Hide resolved
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 14, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG SimFG force-pushed the master branch 3 times, most recently from 87cedcb to 13c33b2 Compare February 14, 2025 12:58
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 14, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Feb 14, 2025

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 14, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Feb 14, 2025

rerun go-sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaime0815 jaime0815 jaime0815 left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@chyezh chyezh Awaiting requested review from chyezh

@congqixia congqixia Awaiting requested review from congqixia

Assignees
No one assigned
Labels
area/dependency Pull requests that update a dependency file area/internal-api area/test dco-passed DCO check passed. kind/feature Issues related to feature request from users sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimFG @sre-ci-robot @jaime0815 @chyezh