Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: add some missing code for Int8Vector #39742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

enhance: add some missing code for Int8Vector #39742

wants to merge 1 commit into from

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Feb 10, 2025

Issue: #38666

@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Feb 10, 2025
@cydrain
Copy link
Contributor Author

cydrain commented Feb 10, 2025

/kind improvement

@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/S Denotes a PR that changes 10-29 lines. labels Feb 10, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 10, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 10, 2025

@cydrain go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 10, 2025

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Feb 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.39%. Comparing base (9bbaaac) to head (7598d35).
Report is 3 commits behind head on master.

❌ Your project check has failed because the head coverage (69.39%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (9bbaaac) and HEAD (7598d35). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9bbaaac) HEAD (7598d35)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39742       +/-   ##
===========================================
- Coverage   80.10%   69.39%   -10.72%     
===========================================
  Files        1488      302     -1186     
  Lines      205586    27077   -178509     
===========================================
- Hits       164687    18790   -145897     
+ Misses      34958     8287    -26671     
+ Partials     5941        0     -5941
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.39% <ø> (ø)
Go ∅ <ø> (∅)

see 1186 files with indirect coverage changes

@cydrain cydrain force-pushed the caiyd_38666_int8vector_full_support branch from 8c53742 to f4cfd07 Compare February 10, 2025 06:20
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cydrain
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added area/test sig/testing size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Feb 10, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 10, 2025

@cydrain go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 10, 2025

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cydrain cydrain force-pushed the caiyd_38666_int8vector_full_support branch 2 times, most recently from a760a69 to 8f9438f Compare February 12, 2025 08:03
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 12, 2025

@cydrain E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 12, 2025

@cydrain go-sdk check failed, comment rerun go-sdk can trigger the job again.

@cydrain cydrain force-pushed the caiyd_38666_int8vector_full_support branch from 8f9438f to 8695024 Compare February 13, 2025 02:22
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2025

@cydrain go-sdk check failed, comment rerun go-sdk can trigger the job again.

@cydrain cydrain force-pushed the caiyd_38666_int8vector_full_support branch from 8695024 to 7598d35 Compare February 14, 2025 02:38
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 14, 2025

@cydrain go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@ThreadDao ThreadDao Awaiting requested review from ThreadDao

Assignees
No one assigned
Labels
area/dependency Pull requests that update a dependency file area/test dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cydrain @sre-ci-robot