Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce Text data type #39874

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

PwzXxm
Copy link
Contributor

@PwzXxm PwzXxm commented Feb 13, 2025

issue: #39818

This PR mimics Varchar data type, allows insert, search, query, delete, full-text search and others.
Functionalities related to filter expressions are disabled temporarily.

Storage changes for Text data type will be in the following PRs.

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file size/L Denotes a PR that changes 100-499 lines. labels Feb 13, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PwzXxm
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Feb 13, 2025
Copy link
Contributor

mergify bot commented Feb 13, 2025

@PwzXxm go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 13, 2025

@PwzXxm E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 75.40984% with 30 lines in your changes missing coverage. Please review.

Project coverage is 80.07%. Comparing base (a54c3fe) to head (7300e06).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/util.go 62.50% 3 Missing and 3 partials ⚠️
internal/core/src/common/Types.h 0.00% 5 Missing ⚠️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 33.33% 4 Missing ⚠️
internal/proxy/validate_util.go 80.95% 4 Missing ⚠️
internal/parser/planparserv2/parser_visitor.go 50.00% 2 Missing and 1 partial ⚠️
internal/core/src/common/ChunkWriter.cpp 50.00% 2 Missing ⚠️
internal/core/src/segcore/Utils.cpp 80.00% 2 Missing ⚠️
.../flushcommon/pipeline/flow_graph_embedding_node.go 0.00% 1 Missing ⚠️
internal/proxy/task_insert.go 50.00% 1 Missing ⚠️
internal/proxy/task_upsert.go 50.00% 1 Missing ⚠️
... and 1 more

❌ Your patch check has failed because the patch coverage (75.40%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39874       +/-   ##
===========================================
+ Coverage   69.39%   80.07%   +10.68%     
===========================================
  Files         302     1488     +1186     
  Lines       27077   205892   +178815     
===========================================
+ Hits        18790   164878   +146088     
- Misses       8287    35067    +26780     
- Partials        0     5947     +5947     
Components Coverage Δ
Client 79.24% <ø> (∅)
Core 69.38% <70.45%> (-0.01%) ⬇️
Go 81.80% <78.20%> (∅)
Files with missing lines Coverage Δ
internal/core/src/common/FieldData.cpp 78.88% <100.00%> (+0.13%) ⬆️
internal/core/src/mmap/Utils.h 82.60% <ø> (ø)
internal/core/src/segcore/ConcurrentVector.cpp 97.05% <100.00%> (+0.04%) ⬆️
internal/core/src/segcore/InsertRecord.h 89.03% <100.00%> (ø)
internal/core/src/segcore/SegmentChunkReader.cpp 53.64% <100.00%> (+0.24%) ⬆️
internal/core/src/segcore/SegmentGrowingImpl.cpp 82.36% <100.00%> (+0.04%) ⬆️
internal/core/src/segcore/SegmentSealedImpl.cpp 84.03% <100.00%> (+0.04%) ⬆️
internal/core/src/storage/Event.cpp 83.15% <ø> (ø)
internal/core/src/storage/Util.cpp 75.29% <100.00%> (+0.14%) ⬆️
internal/proxy/task.go 80.66% <100.00%> (ø)
... and 20 more

... and 1169 files with indirect coverage changes

@PwzXxm PwzXxm force-pushed the text_col branch 2 times, most recently from 2cf814c to 19984b7 Compare February 14, 2025 06:08
Copy link
Contributor

mergify bot commented Feb 14, 2025

@PwzXxm go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: Patrick Weizhi Xu <[email protected]>
Copy link
Contributor

mergify bot commented Feb 14, 2025

@PwzXxm go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 14, 2025

@PwzXxm E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Pull requests that update a dependency file dco-passed DCO check passed. kind/feature Issues related to feature request from users size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants