Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix import failed due to 0 row num #39886

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

bigsheeper
Copy link
Contributor

issue: #39885

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Feb 14, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 14, 2025
@tedxu
Copy link
Contributor

tedxu commented Feb 14, 2025

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Feb 14, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 14, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: bigsheeper <[email protected]>
@sre-ci-robot sre-ci-robot removed the lgtm label Feb 14, 2025
Copy link
Contributor

mergify bot commented Feb 14, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.04%. Comparing base (a54c3fe) to head (a21078b).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/datanode/importv2/task_import.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39886       +/-   ##
===========================================
+ Coverage   69.39%   80.04%   +10.65%     
===========================================
  Files         302     1488     +1186     
  Lines       27077   205833   +178756     
===========================================
+ Hits        18790   164763   +145973     
- Misses       8287    35113    +26826     
- Partials        0     5957     +5957     
Components Coverage Δ
Client 79.24% <ø> (∅)
Core 69.40% <ø> (+<0.01%) ⬆️
Go 81.76% <50.00%> (∅)
Files with missing lines Coverage Δ
internal/datanode/importv2/util.go 63.87% <100.00%> (ø)
internal/datanode/importv2/task_import.go 76.13% <40.00%> (ø)

... and 1185 files with indirect coverage changes

@tedxu
Copy link
Contributor

tedxu commented Feb 14, 2025

rerun go-sdk

@tedxu
Copy link
Contributor

tedxu commented Feb 14, 2025

/lgtm

@mergify mergify bot added the ci-passed label Feb 14, 2025
@sre-ci-robot sre-ci-robot merged commit 5d89838 into milvus-io:master Feb 14, 2025
19 of 20 checks passed
yanliang567 pushed a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants