Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation Link #229

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Add Documentation Link #229

merged 2 commits into from
Sep 30, 2020

Conversation

quentinlesceller
Copy link
Member

@quentinlesceller quentinlesceller commented Sep 28, 2020

Replace GitHub link by "Documentation" link in top bar.

@antiochp
Copy link
Member

Do we still have a reasonably prominent link somewhere to github?

@quentinlesceller
Copy link
Member Author

We still have it at the bottom of the page.
Capture d’écran 2020-09-29 à 13 48 18

@Paouky
Copy link
Contributor

Paouky commented Sep 29, 2020

Considering the core team is likely about to become a council managing the fund, maybe we can keep the GitHub link and instead remove the Governance tab?

@0xmichalis
Copy link
Contributor

There is also a link in the Get Started page that should change to point at the new docs site.

@0xmichalis
Copy link
Contributor

@Paouky
Copy link
Contributor

Paouky commented Sep 29, 2020

@Kargakis I have a PR going to modify the Get Started page.

@lehnberg
Copy link
Contributor

Could we find a way to make room for both Docs and Github in the top menu? Arguably two of the most crucial links for us to have.

@quentinlesceller
Copy link
Member Author

Updated to keep both links. Please review @Paouky @lehnberg @Kargakis @antiochp thanks!
Preview:
Capture d’écran 2020-09-30 à 12 24 47

Copy link
Contributor

@Paouky Paouky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. though I do think we eventually want to minimize the number of tabs up there.

Copy link
Contributor

@0xmichalis 0xmichalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @Paouky about minimizing the tabs in the future. Maybe Governance can be collapsed into Community.

@lehnberg
Copy link
Contributor

Okay, merging for now, we can iterate on the top bar later, related: #172

@lehnberg lehnberg merged commit 0283b48 into mimblewimble:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants