Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Part1: update current onnx export #976

Merged
merged 5 commits into from
Jul 7, 2022

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Jul 5, 2022

This PR:

  • updates current onnx export for further processing in Part2

Part2 : add slow tests (only local testing) for each model

Any feedback is welcome 🤗

@felixdittrich92 felixdittrich92 self-assigned this Jul 5, 2022
@felixdittrich92 felixdittrich92 added framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: onnx ONNX-related labels Jul 5, 2022
@felixdittrich92 felixdittrich92 added this to the 0.6.0 milestone Jul 5, 2022
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #976 (0fd1aef) into main (2e9a4e1) will decrease coverage by 0.03%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
- Coverage   95.18%   95.14%   -0.04%     
==========================================
  Files         134      134              
  Lines        5520     5524       +4     
==========================================
+ Hits         5254     5256       +2     
- Misses        266      268       +2     
Flag Coverage Δ
unittests 95.14% <77.77%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/models/utils/tensorflow.py 95.34% <71.42%> (-4.66%) ⬇️
doctr/models/utils/pytorch.py 100.00% <100.00%> (ø)
doctr/transforms/modules/base.py 94.59% <0.00%> (ø)
doctr/models/recognition/master/tensorflow.py 100.00% <0.00%> (ø)
doctr/models/recognition/transformer/tensorflow.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9a4e1...0fd1aef. Read the comment docs.

Copy link
Collaborator

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) A few questions in comment

doctr/models/utils/pytorch.py Outdated Show resolved Hide resolved
doctr/models/utils/tensorflow.py Outdated Show resolved Hide resolved
doctr/models/utils/tensorflow.py Show resolved Hide resolved
@felixdittrich92 felixdittrich92 requested a review from frgfm July 6, 2022 20:38
@felixdittrich92
Copy link
Contributor Author

@frgfm after testing again opset 14 is the minimum version we need to ensure all operators are supported (have added a comment) otherwise the export fails for some models in both frameworks

We should also update torch to a minimum of 1.10 (first support for opset 14 in #791 requirements update)

Copy link
Collaborator

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: onnx ONNX-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants