Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfill latest_evaluation_statuses with profile_id #4031

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

dmjb
Copy link
Contributor

@dmjb dmjb commented Jul 29, 2024

Backfill this column and make it non nullable. Note that due to the sequencing of production deploys, there should not be any latest_evaluaion_statuses rows in production which do not have a profile_id - this migration is only relevant for staging and local dev environments.

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Backfill this column and make it non nullable. Note that due to the
sequencing of production deploys, there should not be any
`latest_evaluaion_statuses` rows in production which do not have a
`profile_id` - this migration is only relevant for staging and local
dev environments.
@dmjb dmjb requested a review from a team as a code owner July 29, 2024 12:45
@coveralls
Copy link

Coverage Status

coverage: 54.624% (-0.006%) from 54.63%
when pulling 25587db on backfill-latest-eval-profile-id
into eec1a30 on main.

@dmjb dmjb merged commit ed13dbe into main Jul 29, 2024
26 of 27 checks passed
@dmjb dmjb deleted the backfill-latest-eval-profile-id branch July 29, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants