Populate evaluation history tables with old evaluations #4065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
dmjb
force-pushed
the
migrate-rule-evaluations
branch
from
37743fa
to
bfc2146
Compare
10 tasks
dmjb
force-pushed
the
migrate-rule-evaluations
branch
from
57479b9
to
090e737
Compare
dmjb
force-pushed
the
migrate-rule-evaluations
branch
from
18c11b9
to
f45e433
Compare
dmjb
force-pushed
the
migrate-rule-evaluations
branch
2 times, most recently
from
9a4de7b
to
695d7f1
Compare
JAORMX
previously approved these changes
Aug 8, 2024
In order to replace the old rule status tables, we need to populate the evaluation history tables with the statuses of rule evaluations which happened prior to the introduction of the new tables. Once this migration is complete, it will be possible to change the existing profile and rule queries to use the evaluation history tables instead of the old rule evaluation/details tables. Migration validated locally.
dmjb
force-pushed
the
migrate-rule-evaluations
branch
from
690ef7b
to
7787fcf
Compare
JAORMX
approved these changes
Aug 9, 2024
dmjb
added a commit
that referenced
this pull request
Aug 9, 2024
This reverts commit 5e7ff4b. Encountered an issue in staging. Reverting until we can determine the cause of the problem.
dmjb
added a commit
that referenced
this pull request
Aug 9, 2024
psekar
pushed a commit
to tinytrail/minder
that referenced
this pull request
Aug 15, 2024
Refer to PR mindersec#4065 for a description of the change. This was merged in but had to be rolled back due to a bug. That bug was fixed in PR mindersec#4124. As part of this roll out. Part of migration script 88 needs to be repeated to fix any rows affected by that bug before applying it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to replace the old rule status tables, we need to populate the evaluation history tables with the statuses of rule evaluations which happened prior to the introduction of the new tables. Once this migration is complete, it will be possible to change the existing profile and rule queries to use the evaluation history tables instead of the old rule evaluation/details tables.
Migration validated locally.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: