Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate the release_phase response to the related APIs #4278

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Aug 26, 2024

Summary

The following PR takes into account the release_phase request and response to the related APIs:

  • Ruletype - create, update, get, list
  • Profile - added it to RuleEvaluationStatus message (used in getting the detailed profile status and when listing the evaluation results)

Fixes #4245
Fixes #4246

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov force-pushed the add-release-to-api branch 2 times, most recently from 873a6cd to cd8f746 Compare August 26, 2024 13:30
@coveralls
Copy link

coveralls commented Aug 26, 2024

Coverage Status

coverage: 53.838% (-0.03%) from 53.87%
when pulling d8bbad2 on add-release-to-api
into 369ac09 on main.

dmjb
dmjb previously approved these changes Aug 26, 2024
@rdimitrov rdimitrov changed the title Populate the release_phase response to ruletype related APIs Populate the release_phase response to the related APIs Aug 26, 2024
blkt
blkt previously approved these changes Aug 26, 2024
@rdimitrov rdimitrov merged commit 02452cc into main Aug 27, 2024
22 checks passed
@rdimitrov rdimitrov deleted the add-release-to-api branch August 27, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants