Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proto validation for names #4890

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

eleftherias
Copy link
Contributor

Summary

For stacklok entity names (profile, provider, etc) the pattern is [A-Za-z][-[:word:]]*, must start with a letter and may contain dashes, underscores and alphanumeric characters.

For display names the pattern is [[:space:][:punct:][:word:]]*, the characters used to form a sentence.

For external names (repo, artifact, etc) the pattern is [-./[:word:]]*, alphanumeric characters, dashes, underscores, plus dots and slashes.

Ref stacklok/minder-stories#94

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner November 6, 2024 10:50
@coveralls
Copy link

coveralls commented Nov 6, 2024

Pull Request Test Coverage Report for Build 11704048485

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 54.77%

Totals Coverage Status
Change from base Build 11701614228: 0.007%
Covered Lines: 15536
Relevant Lines: 28366

💛 - Coveralls

@eleftherias eleftherias closed this Nov 6, 2024
@eleftherias eleftherias reopened this Nov 6, 2024
@eleftherias eleftherias merged commit e84f804 into mindersec:main Nov 6, 2024
31 checks passed
@eleftherias eleftherias deleted the proto-name-validation branch November 6, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants