Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kick off data sources CRUD API & Minder API Authz #4970

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

teodor-yanev
Copy link
Contributor

@teodor-yanev teodor-yanev commented Nov 14, 2024

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes https://github.com/stacklok/minder-stories/issues/131

@JAORMX Please feel free to adjust this as needed while I'm away.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@teodor-yanev teodor-yanev self-assigned this Nov 14, 2024
@teodor-yanev teodor-yanev requested a review from a team as a code owner November 14, 2024 21:33
@coveralls
Copy link

coveralls commented Nov 14, 2024

Coverage Status

coverage: 54.696% (-0.07%) from 54.765%
when pulling 2b19c6f on data-sources-crud-authz
into f117ed1 on main.

@JAORMX JAORMX force-pushed the data-sources-crud-authz branch from 968891d to 2b19c6f Compare November 15, 2024 14:11
@JAORMX JAORMX merged commit 9b7eaac into main Nov 15, 2024
26 checks passed
@JAORMX JAORMX deleted the data-sources-crud-authz branch November 15, 2024 14:56
@evankanderson
Copy link
Member

As a side note for the future, we should have adjusted the PR title to include "data sources" somewhere in it. I was digging, and I was wondering who thought we didn't have CRUD in the Minder API. 🤣

@teodor-yanev teodor-yanev changed the title Kick off CRUD API & Minder API Authz Kick off data sources CRUD API & Minder API Authz Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants