Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused RetrieveProperty function #5014

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Remove unused RetrieveProperty function #5014

merged 4 commits into from
Nov 20, 2024

Conversation

navnitms
Copy link
Contributor

Summary

Remove RetrieveProperty from properties service

Fixes #4421

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Ran unit tests

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@navnitms navnitms requested a review from a team as a code owner November 20, 2024 20:22
@coveralls
Copy link

coveralls commented Nov 20, 2024 •
edited
Loading

Coverage Status

coverage: 54.592% (-0.05%) from 54.642%
when pulling d44adee on navnitms:remove-unused-RetrieveProperty
into 657bf01 on mindersec:main.

@evankanderson evankanderson merged commit 15a2565 into mindersec:main Nov 20, 2024
25 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson evankanderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove RetrieveProperty from properties service
3 participants
@navnitms @coveralls @evankanderson