Include provider ID in minder CLI response #5029
Conversation
Fixed the issue where deleting a provider by its ID was not possible due to the missing provider ID in the CLI response
| string id = 10 [ | ||
| (buf.validate.field).string = {uuid: true}, | ||
| (buf.validate.field).ignore = IGNORE_IF_DEFAULT_VALUE | ||
| ]; |
There was a problem hiding this comment.
Not strictly required, but you might want to also add the (google.api.field_behavior) = OUTPUT_ONLY annotation, since I expect that we would reject changing the ID on create/update.
Here's an example:
https://github.com/mindersec/minder/blob/main/proto/minder/v1/minder.proto#L3646
There was a problem hiding this comment.
Sure will do a follow up PR to address this
Thanks
| t.AddRow("ID", p.GetId()) | ||
| t.AddRow("Name", p.GetName()) | ||
| t.AddRow("Project", p.GetProject()) | ||
| t.AddRow("Version", p.GetVersion()) |
There was a problem hiding this comment.
This is fine for now, but these wide tables end up being a bit ugly, so we'll probably (at some future point) need to figure out how to collapse them more elgantly. (And a 36-character wide UUID doesn't help, but it's not the only contributor)
|
(The security scan failure is an upstream Trivy issue where they are triggering on their own examples...) |
Fixed the issue where deleting a provider by its ID was not possible due to the missing provider ID in the CLI response
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #5000
Change Type
Mark the type of change your PR introduces:
Testing
Tested the flow using CLI command
minder provider get -n <provider-name>Response :
Review Checklist: