Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the failing auth login command due to missing credentials #5031

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fix the failing auth login command due to missing credentials #5031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cmd/cli/app/auth/auth_login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ $XDG_CONFIG_HOME/minder/credentials.json`,
}

// LoginCommand is the login subcommand
func LoginCommand(ctx context.Context, cmd *cobra.Command, _ []string, conn *grpc.ClientConn) error {
func LoginCommand(ctx context.Context, cmd *cobra.Command, _ []string, _ *grpc.ClientConn) error {
clientConfig, err := config.ReadConfigFromViper[clientconfig.Config](viper.GetViper())
if err != nil {
return cli.MessageAndError("Unable to read config", err)
Expand All @@ -40,6 +40,13 @@ func LoginCommand(ctx context.Context, cmd *cobra.Command, _ []string, conn *grp
return cli.MessageAndError("Error ensuring credentials", err)
}

// Get a connection to the GRPC server after we have the credentials
conn, err := cli.GrpcForCommand(cmd, viper.GetViper())
if err != nil {
return err
}
defer conn.Close()

client := minderv1.NewUserServiceClient(conn)

// check if the user already exists in the local database
Expand Down
Loading