Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource Service Create #5056

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Datasource Service Create #5056

merged 2 commits into from
Nov 26, 2024

Conversation

teodor-yanev
Copy link
Contributor

Summary

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #5044

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@teodor-yanev teodor-yanev self-assigned this Nov 26, 2024
@teodor-yanev teodor-yanev requested a review from a team as a code owner November 26, 2024 14:30
@JAORMX
Copy link
Contributor

JAORMX commented Nov 26, 2024

This LGTM and it's almost ready it go, just gotta fix the linting issues and we can merge this.

@teodor-yanev teodor-yanev merged commit e51bae0 into main Nov 26, 2024
24 checks passed
@teodor-yanev teodor-yanev deleted the add-datasource-create branch November 26, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datasource service: Implement Create function
2 participants