Instantiate data sources from the policy engine #5060
Merged
+183
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hooks data source registration into Minder's policy engine. This is done by populating individual data source registries into each rule type engine, which pertains to a single rule type. This way, each rule type would only have access to the data sources it instantiates. This also caught a segfault we were unaware of. For some reason, the builder of the ruletype engine cache was not populating all the needed members of the struct which would segfault in case the cache did not have a hit. This fixes that. Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
datasources-engine
branch
from
4fbf822
to
58e6ee4
Compare
rdimitrov
approved these changes
Nov 27, 2024
rdimitrov
reviewed
Nov 27, 2024
| // | ||
| // TODO: Do we need to pass in a transaction here? | ||
| // TODO: We _might_ want to pass in a slice of the hierarchy here. | ||
| dsreg, err := dssvc.BuildDataSourceRegistry(ctx, pbRuleType, nil) |
There was a problem hiding this comment.
It's not possible for this to conflict right? I.e. one ruletype having access to the data sources for another one?
There was a problem hiding this comment.
That's right. This is why I make the instantiation of the registry here and per rule type. The registry is not shared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This hooks data source registration into Minder's policy engine. This is
done by populating individual data source registries into each rule type
engine, which pertains to a single rule type. This way, each rule type
would only have access to the data sources it instantiates.
This also caught a segfault we were unaware of. For some reason, the
builder of the ruletype engine cache was not populating all the needed
members of the struct which would segfault in case the cache did not
have a hit. This fixes that.
Closes: #5043
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: