Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set required proto fields in artifact messages #5063

Merged

Conversation

eleftherias
Copy link
Contributor

Summary

Set the fields in artifact messages as required or optional, to generate a correct OpenAPI spec.

Ref #4952

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner November 27, 2024 10:26
@coveralls
Copy link

Coverage Status

coverage: 54.771%. remained the same
when pulling c0aa515 on eleftherias:openapi-artifact-required-fields
into 135cf2f on mindersec:main.

@eleftherias eleftherias merged commit 0cc4d09 into mindersec:main Nov 27, 2024
27 checks passed
@eleftherias eleftherias deleted the openapi-artifact-required-fields branch November 27, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants