Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement validation functions for Data Source protobuf object #5064

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Nov 27, 2024

Summary

This allows us to validate that the different pieces of the data source
protobuf object are valid and usable.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested a review from a team as a code owner November 27, 2024 12:21
This allows us to validate that the different pieces of the data source
protobuf object are valid and usable.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@coveralls
Copy link

coveralls commented Nov 27, 2024

Coverage Status

coverage: 54.778%. remained the same
when pulling cb899a1 on JAORMX:datasource-validation
into 0cc4d09 on mindersec:main.

@JAORMX JAORMX merged commit 0626447 into mindersec:main Nov 27, 2024
25 checks passed
@JAORMX JAORMX deleted the datasource-validation branch November 27, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants