Validate Data Sources when creating rules. #5068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
requested changes
Nov 28, 2024
JAORMX
requested changes
Nov 28, 2024
blkt
force-pushed
the
feat/add-data-source-validation-to-rules
branch
2 times, most recently
from
7d0af56 to
94feeb8
Compare
Rules can now specify a list of data sources names that they need for their evaluation. This change ensures that data sources required by the rule are available when creating the rule. A similar change is being added in the code path implementing data source deletion ensuring that a data source is not deleted if there exist rules depending on it. Fixes #5049
blkt
force-pushed
the
feat/add-data-source-validation-to-rules
branch
from
94feeb8 to
7992ebb
Compare
|
@JAORMX I should have addressed all your concerns, PTAL. |
JAORMX
approved these changes
Nov 28, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rules can now specify a list of data sources names that they need for their evaluation. This change ensures that data sources required by the rule are available when creating the rule.
A similar change is being added in the code path implementing data source deletion ensuring that a data source is not deleted if there exist rules depending on it.
Fixes #5049
Change Type
Testing
Unit tested.
Review Checklist: