Skip to content
This repository has been archived by the owner on Jul 24, 2019. It is now read-only.

Fix hotkey support, add event namespaces, add hotkey enable callback #77

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
8036_Writing_Input_Performance_Issues
- namespace the 'touchend' event bound to window so we can remove it
- throttle 'updateToolbar' so it doesn't get called every keypress
  • Loading branch information
jeffszusz committed Oct 29, 2014
commit 5655bba20e2d83685bdf65f763757e9be69ae875
44 changes: 33 additions & 11 deletions bootstrap-wysiwyg.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,28 @@
}

},
updateToolbar = function () {
throttle = function(handler, threshold, scope) {
var last, deferTimer;
return function() {
var context = scope || this;
var now = new Date().getTime();
var args = arguments;

if (last && now < last + threshold) {
// wait for it...
clearTimeout(deferTimer);
deferTimer = setTimeout(function() {
last = now;
handler.apply(context, args);
}, threshold);

} else {
last = now;
handler.apply(context, args);
}
};
},
updateToolbar = throttle(function () {
if (options.activeToolbarClass) {
$(options.toolbarSelector).find(toolbarBtnSelector).each(function () {
var command = $(this).data(options.commandRole);
Expand All @@ -78,18 +99,19 @@
} else {
commandNoArgs = command;
}
if (commandNoArgs === "fontSize" && options.setRealFontSize != null) {
options.setRealFontSize(selectedRange);
} else if (document.queryCommandState(command)) {
if (document.queryCommandState(command)) {
$(this).addClass(options.activeToolbarClass);
} else if (commandNoArgs + ' ' + document.queryCommandValue(commandNoArgs) === command) {
$(this).addClass(options.activeToolbarClass);
} else {
$(this).removeClass(options.activeToolbarClass);
}
});
if (options.setRealFontSize !== null) {
options.setRealFontSize(selectedRange);
}
}
},
}, 500),
execCommand = function (commandWithArgs, valueArg) {
var commandArr = commandWithArgs.split(' '),
command = commandArr.shift(),
Expand Down Expand Up @@ -154,10 +176,10 @@
var eventNamespace = options.eventNamespace + '-' + 'bindKeys';

editor.on(namespaceEvents('focus'), function(e) {
setTimeout(function() {
restoreCommandCache();
}, 0);
});
setTimeout(function() {
restoreCommandCache();
}, 0);
});

editor.on(namespaceEvents('keydown'), hotKeys, function (e) {
var command = '';
Expand Down Expand Up @@ -302,7 +324,7 @@
commandCache[btnAttr.split(' ')[0]] = false;
});

$(window).bind('touchend', function (e) {
$(window).bind(namespaceEvents('touchend'), function (e) {
var isInside = (editor.is(e.target) || editor.has(e.target).length > 0),
currentRange = getCurrentRange(),
clear = currentRange && (currentRange.startContainer === currentRange.endContainer && currentRange.startOffset === currentRange.endOffset);
Expand All @@ -311,7 +333,7 @@
updateToolbar();
}
});
return this;
return this;
};
$.fn.wysiwyg.defaults = {
hotKeys: {
Expand Down