Fractional scale and fixes #100
Conversation
GameParrot
commented
Jul 12, 2024
GameParrot
commented
- scaling now correctly applies to keystrokes hud
- added fractional scaling
- fixed keystrokes with non default keys (requires restart)
- moved fullscreen option to our own settings file
- tweaked keystrokes color to improve visibility on white background
- scaling now correctly applies to keystrokes hud - added fractional scaling - fixed keystrokes with non default keys (requires restart) - moved fullscreen option to our own settings file
makes it visible on white background
|
I never added fractional scaling because imgui truncates all sizes after a fractional scaling https://github.com/ocornut/imgui/blob/126569ad5b3a2c5329cc8ee914dd5b2075f4dd50/imgui.cpp#L1298 So my call to this method will randomize imgui scaling, as long we don't reset all sizes on change and skip diving via old scale |
fractional scale looks fine for me |
|
What happens if you flip 2-10 times between two or more fractional scales? I predict that the border sizes will vary by 1-?? pixels compared to the sizes used after open and not going back to the sizes it used initially |
|
this code get's run during switching scales lround(lround(17px / 100%* 125%) / 125% * 100%) Now replace 125 and 100 by random scales, it is unlikely there is no loss in pixels For integer scales is no loss in precision in that code |
|
I would probably fix this and get this merged, but this needs to be addressed |
|
I mean this bug: vs. the correct one |
|
@GameParrot I don't see why you added 25%-75% scales, e.g. on ubuntu/windows scaling lower bounds are always 100% I also switched the display format to percent to match the other UI scaleing settings |
|
Thanks for this change, your hud looks much better now when applying scaling |
