Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sha256 function to lua controller #690

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

Darin755
Copy link
Contributor

This is a simple solution for #689

Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about sha1?
any documentation that needs updating?

@Darin755
Copy link
Contributor Author

Darin755 commented Nov 22, 2024

sha1 is not secure as it has known hash collisions. (where two different inputs get the same hash) It also is pretty easy to brute force.

I could probably add this to the docs. However, the lua controller docs are dated and not great so if get around to working on docs I will likely make some big changes.

@sfan5
Copy link
Member

sfan5 commented Dec 7, 2024

It looks like the documentation isn't even in this repo, so should be fine as is.

@sfan5 sfan5 merged commit d547f5f into minetest-mods:master Dec 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants