Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Conserve left-over microblocks." (RE-PUBLISHED) #197

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

"Conserve left-over microblocks." (RE-PUBLISHED) #197

wants to merge 4 commits into from

Conversation

The4codeblocks
Copy link
Contributor

This commit conserves the microblocks so that they are never lost. Previously, any left-over microblocks were destroyed if the
input box was manually emptied or if anything was taken from the output while the input box is empty.

Commits originally from @fozolo.

@The4codeblocks
Copy link
Contributor Author

The4codeblocks commented Jul 13, 2023 •
edited
Loading

NOTE:
THESE COMMITS ARE TAKEN FROM #108.
I ONLY RE-PUBLISHED IT TO MAKE IT COMPATIBLE WITH THE CURRENT VERSION.

FULL CREDIT GOES TO @fozolo.

@Calinou Calinou added the Bug label Jul 13, 2023
Calinou
Calinou reviewed Jul 13, 2023
View reviewed changes
circular_saw.lua Outdated Show resolved Hide resolved
Calinou
Calinou approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on my end, but I'm always a bit worried about this accidentally introducing a duplication glitch.

I guess it could be merged now and make a release only after a few weeks have passed.

@The4codeblocks
Copy link
Contributor Author

The4codeblocks commented Jul 13, 2023 •
edited
Loading

Certain warning.
image
Oh well.
That "unused value" is actually an initialization empty string.
Is it ok to just make it local node_name?

@Calinou
Copy link
Member

Calinou commented Jul 13, 2023 •
edited
Loading

Is it ok to just make it local node_name?

Sure, but I'm surprised luacheck even complains about it in the first place.

@The4codeblocks
Copy link
Contributor Author

oof
image

@The4codeblocks
Copy link
Contributor Author

With current code, I'd expect error() to be called, but it isn't.
image
image
Maybe that's the issue.

@The4codeblocks The4codeblocks marked this pull request as draft July 13, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@The4codeblocks @Calinou