Compatibility with Voxelibre #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add |
|
Got it, thanks! |
SmallJoker
reviewed
Jul 21, 2024
JadedCtrl
force-pushed
the
master
branch
2 times, most recently
from
f499d54 to
c3fdc07
Compare
This allows skinsdb to replace or supplement Voxelibre’s skin system, using its mcl_skins. Downgrades player_api to an optional dependency.
SmallJoker
reviewed
Jul 24, 2024
There was a problem hiding this comment.
Does not work with .-separated skins. That notation was introduced to get rid of ambiguous skin names.
ERROR[Main]: ModError: Failed to load and run script from MT/games/VoxeLibre/mods/ITEMS/mcl_maps/init.lua:
ERROR[Main]: MT/builtin/game/register.lua:75: Name mcl_maps:filled_map_character.6_male_crea does not follow naming conventions: contains unallowed characters
ERROR[Main]: stack traceback:
ERROR[Main]: [C]: in function 'error'
ERROR[Main]: MT/builtin/game/register.lua:75: in function 'check_modname_prefix'
ERROR[Main]: MT/builtin/game/register.lua:133: in function 'register_item'
ERROR[Main]: MT/builtin/game/register.lua:226: in function 'register_node'
ERROR[Main]: MT/games/VoxeLibre/mods/ITEMS/mcl_maps/init.lua:269: in main chunk
| @@ -8,6 +8,9 @@ skins = {} | |||
| skins.modpath = minetest.get_modpath(minetest.get_current_modname()) | |||
| skins.default = "character" | |||
|
|
|||
| skins.use_voxelibre_compat = minetest.global_exists("mcl_skins") | |||
| assert(minetest.global_exists("player_api") or minetest.global_exists("mcl_skins"), "One of player_api or mcl_skins is required.") | |||
There was a problem hiding this comment.
Applying general Minetest code style rules here.
Suggested change
| assert(minetest.global_exists("player_api") or minetest.global_exists("mcl_skins"), "One of player_api or mcl_skins is required.") | |
| assert(minetest.global_exists("player_api") or minetest.global_exists("mcl_skins"), | |
| "One of player_api or mcl_skins is required.") |
| @@ -60,6 +78,9 @@ function skins.update_player_skin(player) | |||
| if minetest.global_exists("sfinv") and sfinv.enabled then | |||
| sfinv.set_player_inventory_formspec(player) | |||
| end | |||
| if skins.use_voxelibre_compat then | |||
| mcl_skins.update_player_skin(player); | |||
There was a problem hiding this comment.
Suggested change
| mcl_skins.update_player_skin(player); | |
| mcl_skins.update_player_skin(player) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All skins from skinsdb are registered as “simple skins” with mcl_skins, and can be selected using either skindb’s interface or Voxelibre’s own.
Not sure if this is the most elegant way of getting mcl_skins and skinsdb to get along, but it seems to work well enough! ^^