Giveme form: Respect stack_max
#250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What issue does this solve? |
|
Just optional visual fixes. With this change, players are no longer confused about “why can I get 99 tools in a stack and why I only get 1”, etc. I can make this an opt-in if that’d be better. |
|
Then this formspec could be changed to hide the other "give me" buttons when a tool is selected in the craft guide. Other items can be stacked just fine, thus I don't think such limit is needed there. |
SmallJoker
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the "giveme form" so it respects stack_max. The input validation is not added as having oversized stacks is technically safe (and when you have
give, the admin doesn't care how many you get).